----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3111/#review10528 -----------------------------------------------------------
Ship it! Minor comment concerns for ao2_iterator_count() since node is not a valid term there. branches/12/include/asterisk/astobj2.h <https://reviewboard.asterisk.org/r/3111/#comment19971> How about: Get a count of the iterated container objects. branches/12/include/asterisk/astobj2.h <https://reviewboard.asterisk.org/r/3111/#comment19972> Just remove the note as the count returned could change due to other thread activity on the iterated container. branches/12/include/asterisk/astobj2.h <https://reviewboard.asterisk.org/r/3111/#comment19973> The number of objects in the iterated container. - rmudgett On Jan. 8, 2014, 1:31 p.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3111/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2014, 1:31 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23053 > https://issues.asterisk.org/jira/browse/ASTERISK-23053 > > > Repository: Asterisk > > > Description > ------- > > This corrects the ao2_iterator opacity violations in res_pjsip_session.c by > adding a global function to get the number of elements inside the container > hidden behind the iterator. > > > Diffs > ----- > > branches/12/res/res_pjsip_session.c 405091 > branches/12/main/astobj2.c 405091 > branches/12/include/asterisk/astobj2.h 405091 > > Diff: https://reviewboard.asterisk.org/r/3111/diff/ > > > Testing > ------- > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
