----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3116/#review10557 -----------------------------------------------------------
Ship it! Ship It! - Matt Jordan On Jan. 9, 2014, 5:07 p.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3116/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2014, 5:07 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23010 > https://issues.asterisk.org/jira/browse/ASTERISK-23010 > > > Repository: Asterisk > > > Description > ------- > > Setting the channel state to down is not done anywhere in chan_sip except > handle_invite_replaces() after masquerading, and can interfere with the > subsequent hangup of the channel. Removing it appears to make sense, and > causes no problems, although I was unable to observe a new BYE message in the > packet trace of test sip_one_legged_transfer. > > > Diffs > ----- > > /branches/1.8/channels/chan_sip.c 405265 > > Diff: https://reviewboard.asterisk.org/r/3116/diff/ > > > Testing > ------- > > Ran all SIP tests in testsuite before and after, no new failures. > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
