----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3140/#review10695 -----------------------------------------------------------
Ship it! Ship It! - Mark Michelson On Jan. 18, 2014, 5:17 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3140/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2014, 5:17 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23082 > https://issues.asterisk.org/jira/browse/ASTERISK-23082 > > > Repository: Asterisk > > > Description > ------- > > There exists functionality within the Asterisk core to allow a set of > requested capabilities to be passed to channel drivers when placing outgoing > calls. The implementation within channel drivers for how to handle this has > widely differed. Some drivers ignore it, some drivers just add the > capabilities to the configured ones. The chan_pjsip module has gone to the > extreme of *only* using the requested capabilities and not the configured > ones. This would normally be fine except the core prunes the capabilities > down to only a single audio codec in all cases. Depending on configuration > this would cause only a single codec to be present in the SDP. The attached > change makes it so the requested capabilities are added to the configured > ones, allowing the configured ones to also be present in the SDP. > > > Diffs > ----- > > /branches/12/res/res_pjsip_session.c 405776 > > Diff: https://reviewboard.asterisk.org/r/3140/diff/ > > > Testing > ------- > > Placed calls, confirmed that configured codecs are being sent now. Ran test > and confirmed it passes with change. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
