> On Jan. 24, 2014, 10:15 p.m., Kevin Harwell wrote: > > /asterisk/trunk/lib/python/asterisk/pluggable_modules.py, line 271 > > <https://reviewboard.asterisk.org/r/3151/diff/1/?file=53069#file53069line271> > > > > Parent method calls should also now be called with "super".
Unfortunately, this can only be done if the parent class is a descendant of object. In this case, pj.AccountCallback is the base of the tree and does not derive from object, so super can't be used. > On Jan. 24, 2014, 10:15 p.m., Kevin Harwell wrote: > > /asterisk/trunk/tests/channels/pjsip/presence_xpidf/state_check.py, lines > > 40-54 > > <https://reviewboard.asterisk.org/r/3151/diff/1/?file=53082#file53082line40> > > > > Once the test fails and the reactor stops is there a need to continue > > on? I don't think it would cause a problem, but just wondering. Stopping the reactor stops test execution entirely from what I understand. It's basically like throwing an exception in that it does not continue past that point. - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3151/#review10693 ----------------------------------------------------------- On Jan. 23, 2014, 10:52 p.m., Mark Michelson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3151/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2014, 10:52 p.m.) > > > Review request for Asterisk Developers. > > > Repository: testsuite > > > Description > ------- > > When creating the changes on https://reviewboard.asterisk.org/r/3150/, I > realized that there were no subscription tests in the testsuite for res_pjsip > yet. > > In order to properly test subscriptions, I could not use SIPp, since removing > the subscription requires the ability to handle two active transactions, and > SIPp chokes when that happens. Since PJSUA is smarter and has python > bindings, I decided to use that instead for the tests. In oder to do things > the right way(tm), I decided to create a pluggable module for the testsuite > that allows for PJSUA transports, accounts, and buddies to be created using > yaml. Once all PJSUA accounts are registered, then a specified callback can > be called to continue the test. > > As far as actual tests are concerned, I've added three tests that use the new > PJSUA plugin. There are two presence tests that test PIDF and XPIDF, and > there is an MWI test. I was forced to use unsolicited MWI for the MWI test > since the PJSUA python bindings do not have the ability to convey that an > account should subscribe for MWI. > > > Diffs > ----- > > /asterisk/trunk/tests/channels/pjsip/tests.yaml 4595 > /asterisk/trunk/tests/channels/pjsip/presence_xpidf/test-config.yaml > PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/presence_xpidf/state_check.py > PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/presence_xpidf/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/presence_xpidf/configs/ast1/modules.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/presence_xpidf/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/presence_pidf/test-config.yaml > PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/presence_pidf/state_check.py > PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/presence_pidf/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/presence_pidf/configs/ast1/modules.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/presence_pidf/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/mwi/test-config.yaml PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/mwi/mwi_check.py PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/mwi/configs/ast1/pjsip.conf > PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/mwi/configs/ast1/modules.conf > PRE-CREATION > /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 4595 > > Diff: https://reviewboard.asterisk.org/r/3151/diff/ > > > Testing > ------- > > The tests pass. > > > Thanks, > > Mark Michelson > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
