-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3155/
-----------------------------------------------------------
(Updated Jan. 29, 2014, 8:26 a.m.)
Review request for Asterisk Developers.
Changes
-------
Addressed Mark's and Richard's comments.
Bugs: PQ-1396
https://issues.asterisk.org/jira/browse/PQ-1396
Repository: Asterisk
Description
-------
Currently, when the first marked user enters the conference that contains
waitmarked users, a prompt is played indicating that the user is being placed
into the conference. Unfortunately, this prompt is played to the marked user
and not the waitmarked users which is not very helpful.
This patch changes that behavior to play a prompt stating "The conference will
now begin" to the entire conference after adding and unmuting the waitmarked
users since the design of confbridge is not conducive to playing a prompt to a
subset of users in a conference in an asynchronous manner.
Diffs (updated)
-----
branches/11/configs/confbridge.conf.sample 406774
branches/11/apps/confbridge/include/confbridge.h 406774
branches/11/apps/confbridge/conf_state_multi_marked.c 406774
branches/11/apps/confbridge/conf_config_parser.c 406774
branches/11/apps/app_confbridge.c 406774
Diff: https://reviewboard.asterisk.org/r/3155/diff/
Testing (updated)
-------
Verified that the prompt is heard by users already in the conference when a
marked user enters and that ConfBridge tests pass with modified event
expectations.
Thanks,
opticron
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
