----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3153/#review10731 -----------------------------------------------------------
/asterisk/trunk/tests/apps/dial/action_post_answer/called_party_continue/test-config.yaml <https://reviewboard.asterisk.org/r/3153/#comment20224> I suggest adding a channel field to this userevent and ensuring it's the dialed channel that is executing the userevent and not the calling channel. /asterisk/trunk/tests/apps/dial/action_post_answer/caller_continue/test-config.yaml <https://reviewboard.asterisk.org/r/3153/#comment20225> Same suggestion here as with the previous test, except ensure it's the calling channel that causes the userevent to be sent. /asterisk/trunk/tests/apps/dial/mid_call_events/dial_gosub/configs/ast1/extensions.conf <https://reviewboard.asterisk.org/r/3153/#comment20226> redness /asterisk/trunk/tests/apps/dial/mid_call_events/dial_macro/configs/ast1/extensions.conf <https://reviewboard.asterisk.org/r/3153/#comment20227> redditude /asterisk/trunk/tests/apps/dial/mid_call_events/dial_macro/configs/ast1/extensions.conf <https://reviewboard.asterisk.org/r/3153/#comment20228> redacity - Mark Michelson On Jan. 24, 2014, 6:09 p.m., Matt Jordan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3153/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 6:09 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23164 > https://issues.asterisk.org/jira/browse/ASTERISK-23164 > > > Repository: testsuite > > > Description > ------- > > Mid-call events, the 'h' extension, and moving channels around during/after a > Dial operation currently play merry hell with CDRs. As it turned out, as I > was fixing those problems I found a couple of other bugs in Dial, so I went > ahead and wrote these tests. This includes: > > * Mid-call events (GoSub/Macro): ensure that we don't get extra CDR records; > that the application is still Dial after dialplan execution in the final > record; and that the dial status afterwards is the result of the GoSub/Macro > evaluation > * After-bridge actions: This includes the F,G, and g option. Some of these > are after-bridge, some prevent the bridge from happening in the first place. > The tests verify that the correct dialplan actions take place, and for 12, > that the expected CDR entries are created. > * 'h' extension execution of the peer. This should not only happen, but not > create an extra CDR. > > > Diffs > ----- > > /asterisk/trunk/tests/apps/dial/tests.yaml 4579 > /asterisk/trunk/tests/apps/dial/peer_h_exten/test-config.yaml PRE-CREATION > /asterisk/trunk/tests/apps/dial/peer_h_exten/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/apps/dial/mid_call_events/tests.yaml PRE-CREATION > /asterisk/trunk/tests/apps/dial/mid_call_events/dial_macro/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/apps/dial/mid_call_events/dial_macro/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/apps/dial/mid_call_events/dial_gosub/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/apps/dial/mid_call_events/dial_gosub/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/apps/dial/action_post_answer/tests.yaml PRE-CREATION > > /asterisk/trunk/tests/apps/dial/action_post_answer/party_transfer/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/apps/dial/action_post_answer/party_transfer/configs/ast1/extensions.conf > PRE-CREATION > > /asterisk/trunk/tests/apps/dial/action_post_answer/caller_continue/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/apps/dial/action_post_answer/caller_continue/configs/ast1/extensions.conf > PRE-CREATION > > /asterisk/trunk/tests/apps/dial/action_post_answer/called_party_continue/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/apps/dial/action_post_answer/called_party_continue/configs/ast1/extensions.conf > PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3153/diff/ > > > Testing > ------- > > Tests pass with modifications to be put up on a separate review. > > > Thanks, > > Matt Jordan > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
