-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3188/
-----------------------------------------------------------
Review request for Asterisk Developers.
Summary (updated)
-----------------
format_wav: enhancing log message "Not a wav file" to be clear on what is
supported
Bugs: ASTERISK-22310
https://issues.asterisk.org/jira/browse/ASTERISK-22310
Repository: Asterisk
Description (updated)
-------
>From Jim's report:
"The following error message lies. Many things are WAV files which do not
contain 1 in the format field.
if (ltohs(format) != 1) {
ast_log(LOG_WARNING, "Not a wav file %d\n", ltohs(format));
Given how unusual the .WAV vs. .wav distinction is I'd go for: "Not a supported
wav file format (%d). Only PCM encoded versions are supported with a lower-case
'.wav' extension."
Which would be helpful."
The message I've suggested in the patch is:
"Not a supported wav file format (%d). Only PCM encoded, 16 bit, mono, 8kHz
files are supported with a lowercase '.wav' extension.\n"
Please let me know:
1) Is the message content accurate according to format_wav.c ?
2) Is the message more understandable and less ambiguous than the original?
Diffs
-----
Diff: https://reviewboard.asterisk.org/r/3188/diff/
Testing
-------
Thanks,
rnewton
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
