----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3183/#review10784 -----------------------------------------------------------
/branches/12/res/ari/resource_channels.c <https://reviewboard.asterisk.org/r/3183/#comment20332> I feel the following prototype would be better for the caller: static int json_to_ast_variables(struct ast_json *src, struct ast_variable **dest); Return 0 or -1 for success/failure. This way the caller can tell between a failure and an empty json_variables object. /branches/12/res/ari/resource_channels.c <https://reviewboard.asterisk.org/r/3183/#comment20333> If we actually failed to create variables that were requested, we should abort the Originate. Half-success is worse than total failure. - Corey Farrell On Feb. 6, 2014, 10:05 a.m., Matt Jordan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3183/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2014, 10:05 a.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This patch tweaks the behaviour of POST /channels with channel variables such > that the variables are passed into the pbx.c routines that perform the > origination. This allows the variables to be assigned to the newly created > channels immediately upon their construction, as opposed to be assigned after > the originate has completed. > > The upshot of this is that the variables are available on the channels if > they execute in the dialplan, as opposed to only being available once the > channels are answered. > > > Diffs > ----- > > /branches/12/res/ari/resource_channels.c 407562 > > Diff: https://reviewboard.asterisk.org/r/3183/diff/ > > > Testing > ------- > > Both testsuite originate tests still pass. > > > Thanks, > > Matt Jordan > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
