> On Feb. 6, 2014, 9:52 a.m., Joshua Colp wrote: > > While this works I'm not happy with pushing this down to such a low level. > > What if in the future I want to filter something else? > > > > What I'd really like to see is something on top which allows you to > > arbitrarily filter anything. If something similar came up in the future > > then we'd have an immediate easy solution with no core changes and it would > > also allow the information to still exist for cases where you do want to > > get it.
The other option would be to add another parameter to the ast_sorcery_object_field_register() which would indicate a "hidden" option. I can write that up as a separate review and see which one is preferred. Which is now up for review: https://reviewboard.asterisk.org/r/3193/ - Scott ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3136/#review10786 ----------------------------------------------------------- On Feb. 3, 2014, 2:18 p.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3136/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2014, 2:18 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23092 > https://issues.asterisk.org/jira/browse/ASTERISK-23092 > > > Repository: Asterisk > > > Description > ------- > > WAS: > > Insert a ! prefix in the display of endpoint disallow value. Result is: > > disallow : !(ulaw|alaw) > > NOW: > > Remove the disallow option from generated lists, while still accepting it > from a configuration file. > > > Diffs > ----- > > /branches/12/res/res_pjsip/pjsip_configuration.c 407196 > /branches/12/main/sorcery.c 407196 > /branches/12/main/config_options.c 407196 > /branches/12/include/asterisk/config_options.h 407196 > > Diff: https://reviewboard.asterisk.org/r/3136/diff/ > > > Testing > ------- > > Ran command and checked output. > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
