----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3194/#review10827 -----------------------------------------------------------
Ship it! Good changes. - Tilghman Lesher On Feb. 7, 2014, 10:29 a.m., wdoekes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3194/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2014, 10:29 a.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > (1) When doing ast_update2_realtime with res_config_pgsql if you try to set > more than one value, you'll be missing a comma. Example: > > PostgreSQL RealTime: Query Failed: > UPDATE h42_voicemail SET context='f5f9852e-4ed9-c68d-db13-6fcf044bff42' > mailbox='502' WHERE context='f5f9852e-4ed9-c68d-db13-6fcf044bff42' AND > mailbox='502' > > added first=0 to get the missing ',' in there > > (2) Thread local storage was freed in certain off-nominal code paths. > > removed two ast_free(sql)'s > > (3) Moved a few spaces for readability. > > > Diffs > ----- > > /branches/1.8/res/res_config_pgsql.c 407620 > > Diff: https://reviewboard.asterisk.org/r/3194/diff/ > > > Testing > ------- > > No. > > > Thanks, > > wdoekes > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
