> On Feb. 7, 2014, 1:39 a.m., rmudgett wrote: > > /branches/12/main/codec_builtin.c, lines 358-369 > > <https://reviewboard.asterisk.org/r/3178/diff/1/?file=53407#file53407line358> > > > > Is there a > > lpc10_lenght() > > needed?
These implementations come from what we already have. If any are missing it's because we didn't have them. - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3178/#review10821 ----------------------------------------------------------- On Feb. 7, 2014, 2:59 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3178/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2014, 2:59 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This change has a few things in it: > > 1. Some media related things have been moved around to more logical places or > their own parts (smoothers). > > 2. A new implementation of media formats according to > https://wiki.asterisk.org/wiki/display/AST/Media+Format+Rewrite. The > implementation doesn't completely adhere to the design since I tweaked things > but it mostly conforms. > > 3. Unit tests for the above implementation. > > What I'd like feedback on is the actual media formats implementation and the > API design itself. Is this something you would be comfortable using? > > > Diffs > ----- > > /branches/12/tests/test_format_cap.c PRE-CREATION > /branches/12/tests/test_format_cache.c PRE-CREATION > /branches/12/tests/test_core_format.c PRE-CREATION > /branches/12/tests/test_core_codec.c PRE-CREATION > /branches/12/res/res_rtp_asterisk.c 407438 > /branches/12/res/res_fax.c 407438 > /branches/12/main/smoother.c PRE-CREATION > /branches/12/main/frame.c 407438 > /branches/12/main/format_ng.c PRE-CREATION > /branches/12/main/format_cap_ng.c PRE-CREATION > /branches/12/main/format_cache.c PRE-CREATION > /branches/12/main/format.c 407438 > /branches/12/main/codec_builtin.c PRE-CREATION > /branches/12/main/codec.c PRE-CREATION > /branches/12/main/asterisk.c 407438 > /branches/12/include/asterisk/vector.h 407438 > /branches/12/include/asterisk/smoother.h PRE-CREATION > /branches/12/include/asterisk/frame.h 407438 > /branches/12/include/asterisk/format_ng.h PRE-CREATION > /branches/12/include/asterisk/format_cap_ng.h PRE-CREATION > /branches/12/include/asterisk/format_cache.h PRE-CREATION > /branches/12/include/asterisk/format.h 407438 > /branches/12/include/asterisk/codec.h PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3178/diff/ > > > Testing > ------- > > Ran unit tests, all passed. > > Note: I know AO2 throws a fit and it's because a container isn't getting > initialized. Getting said container initialized requires beginning the > hacking apart process. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
