----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3195/#review10826 -----------------------------------------------------------
Ship it! Looks good to me! (Or at least, good enough for now.) /asterisk/trunk/tests/dynamic-modules/run-test <https://reviewboard.asterisk.org/r/3195/#comment20415> This manual .base concatenation which occurs in many places should really be refactored into something like: isfile("%s/%s" % ( self.ast[0].get_instance_dir("astmoddir"), modules[0])) where get_instance_dir(something) returns base contatenated with directories[something], and get_source_dir() does the same but concatenated with localtest_root. Or better: self.ast[0].get_instance_file("astmoddir", module[0]) But that's for another rainy day. - wdoekes On Feb. 7, 2014, 1:41 p.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3195/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2014, 1:41 p.m.) > > > Review request for Asterisk Developers and wdoekes. > > > Bugs: ASTERISK-23244 > https://issues.asterisk.org/jira/browse/ASTERISK-23244 > > > Repository: testsuite > > > Description > ------- > > * Set appropriate defaults for configure / menuselect when done by > './run-local setup' > * Create asterisk.original_astmoddir for use by dependency checking > * Fix path usage in tests/example and tests/dynamic-modules > > > Diffs > ----- > > /asterisk/trunk/tests/example/run-test 4663 > /asterisk/trunk/tests/dynamic-modules/run-test 4663 > /asterisk/trunk/run-local 4663 > /asterisk/trunk/lib/python/asterisk/test_config.py 4663 > /asterisk/trunk/lib/python/asterisk/asterisk.py 4663 > > Diff: https://reviewboard.asterisk.org/r/3195/diff/ > > > Testing > ------- > > Ran tests/cdr and tests/channels/SIP in both local and system mode. > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
