----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3200/#review10833 -----------------------------------------------------------
branches/12/res/res_pjsip/pjsip_cli.c <https://reviewboard.asterisk.org/r/3200/#comment20422> alloca can never fail because it will blow the stack in failure. Also use ast_alloca() instead. branches/12/res/res_pjsip/pjsip_cli.c <https://reviewboard.asterisk.org/r/3200/#comment20421> ast_variable_list_sort() has its own memory leak. It is leaking top and the ast_calloc() is not checked for failure. Top should not be allocated but declared as struct ast_variable top and then memset to zero - rmudgett On Feb. 7, 2014, 3:07 p.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3200/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2014, 3:07 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23266 > https://issues.asterisk.org/jira/browse/ASTERISK-23266 > > > Repository: Asterisk > > > Description > ------- > > I left out 2 ast_variables_destroy() calls so the variables allocated by > ast_sorcery_objectset_create() never get released. > > It leaks whenever someone does a > pjsip show <object_type> <object_id> > from the command line. > > Added the 2 calls before the error and success returns. > > > Diffs > ----- > > branches/12/res/res_pjsip/pjsip_cli.c 407750 > > Diff: https://reviewboard.asterisk.org/r/3200/diff/ > > > Testing > ------- > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
