----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3205/#review10864 -----------------------------------------------------------
Ship it! Ship It! - Matt Jordan On Feb. 10, 2014, 6:25 p.m., Mark Michelson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3205/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2014, 6:25 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This is just to clear up something that's been bothering me for a while now. > > PJSIP provides an MWI-specific API that can be used to handle incoming MWI > subscriptions. The way we are using it nets us pretty much no benefit at all, > and it comes at the expense of having to have odd corner cases in our code > for MWI subscriptions. > > This patch removes all of PJSIP's MWI library code in favor of generic PJSIP > evsub code. This makes the pubsub core code much cleaner, and in my opinion, > makes the res_pjsip_mwi.c code more concise. > > > Diffs > ----- > > /branches/12/res/res_pjsip_pubsub.c 407935 > /branches/12/res/res_pjsip_mwi.c 407935 > > Diff: https://reviewboard.asterisk.org/r/3205/diff/ > > > Testing > ------- > > Ran a manual test with a Digium phone that subscribes to MWI. Tested > unsolicited MWI using the testsuite's MWI test. > > > Thanks, > > Mark Michelson > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
