----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3226/#review10893 -----------------------------------------------------------
Ship it! Ship It! - rmudgett On Feb. 17, 2014, 10:26 a.m., Kevin Harwell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3226/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2014, 10:26 a.m.) > > > Review request for Asterisk Developers and Olle E Johansson. > > > Bugs: ASTERISK-19499 > https://issues.asterisk.org/jira/browse/ASTERISK-19499 > > > Repository: Asterisk > > > Description > ------- > > This is a re-post of https://reviewboard.asterisk.org/r/3170/ that has been > ported to 1.8. > > After acquiring inspiration from Olle's branch and some suggestions from Mark > Michelson (see dev list discussion - > http://lists.digium.com/pipermail/asterisk-dev/2014-February/065266.html) I > updated the code to check to see if MOH is playing on the transferor and if > so then start it on the channel that overwrites it during a masquerade. > > Example scenario of the problem: > Alice calls Bob and then Bob begins the attended transfer process into a > queue. Upon going on hold Alice hears music and so does Bob once he is in > the queue. Bob then transfers Alice into the queue and then music for Alice > stops even though she should be hearing it since has now replaced Bob in the > queue. > > The problem that was occuring is that once the channel was masqueraded the > app (queues, confbridge, etc...) had no way of knowing that the channel had > just been swapped out thus it did not start music for the present channel. > > > Diffs > ----- > > branches/1.8/main/channel.c 408136 > branches/1.8/channels/chan_sip.c 408136 > > Diff: https://reviewboard.asterisk.org/r/3226/diff/ > > > Testing > ------- > > Tested it against queues in 1.8 and queues and confbridges in 11+ and for > chan_pjsip in 12. > > > Thanks, > > Kevin Harwell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
