-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3255/
-----------------------------------------------------------

Review request for Asterisk Developers, Joshua Colp, Kevin Harwell, and Matt 
Jordan.


Bugs: ASTERISK-22911
    https://issues.asterisk.org/jira/browse/ASTERISK-22911


Repository: testsuite


Description
-------

Tests for a crash occurring in 11.7 when ICE on SIP calls (reproduced from a 
SIPML5 with 6 total candidate fields in SDP) when holding. The crash is caused 
by an initially failed ICE session startup followed by a second attempt at 
doing the startup when a HOLD is received. The crash was resolved in 11.8, but 
in the process some people lost audio at the start of similar calls that 
previously worked in 11.7

The test itself is a near duplicate of the existing SIP hold tests, but 
slightly simplified and with some changes in the call flow. A starts the call 
and engages hold and unhold. At the conclusion of unhold if all MOH events went 
through the test will be considered successful.


Diffs
-----

  /asterisk/trunk/tests/channels/SIP/tests.yaml 4726 
  /asterisk/trunk/tests/channels/SIP/sip_hold_ice/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_hold_ice/sipp/phone_B.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_hold_ice/sipp/phone_A.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_hold_ice/sipp/inject_bridge.csv 
PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_hold_ice/run-test PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_hold_ice/configs/ast1/sip.conf 
PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_hold_ice/configs/ast1/rtp.conf 
PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_hold_ice/configs/ast1/extensions.conf 
PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/3255/diff/


Testing
-------

Ran test against 11.7. Crashed
Ran test against 11.8. Did not crash.

Ran test against a diagnostic patch I made to check the PJ_NATH errors that 
were occurring to make sure everything mirrored the results I had been seeing 
in my reproduction efforts.


Thanks,

Jonathan Rose

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to