----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3238/#review10967 -----------------------------------------------------------
Ship it! This looks good other than the minor item below. /asterisk/trunk/lib/python/asterisk/pjsua_mod.py <https://reviewboard.asterisk.org/r/3238/#comment20590> Red blob. - opticron On Feb. 19, 2014, 4:40 p.m., Mark Michelson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3238/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 4:40 p.m.) > > > Review request for Asterisk Developers. > > > Repository: testsuite > > > Description > ------- > > When writing code changes for /r/3237, I wrote this test just to be sure that > MWI aggregation worked appropriately. I also realized that there weren't any > tests that had multiple PJSUA accounts configured, so a simple test that > exercised that would be a good plan. > > Of note, I had to make a change to the PJSUA loadable module so that the > registration checks were performed in the reactor thread. I was getting a > race condition where sometimes the registration from a configured account > would not be acknowledged, leading to a reactor timeout. With the changes > presented here, the test passed 100% of the time on my box. > > > Diffs > ----- > > /asterisk/trunk/tests/channels/pjsip/tests.yaml 4701 > /asterisk/trunk/tests/channels/pjsip/mwi_aggregate/test-config.yaml > PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/mwi_aggregate/mwi_check.py > PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/mwi_aggregate/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/mwi_aggregate/configs/ast1/modules.conf > PRE-CREATION > /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4701 > > Diff: https://reviewboard.asterisk.org/r/3238/diff/ > > > Testing > ------- > > > Thanks, > > Mark Michelson > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
