----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3279/#review10991 -----------------------------------------------------------
I'm not sure I understand the need for this patch. Setting a configuration option twice - when that option doesn't support being set multiple times - would generally have undefined behaviour. Your patch changes it so that Asterisk reads the last defined value, as opposed to the first. How is that better? - Matt Jordan On Feb. 27, 2014, 7:44 p.m., Paul Belanger wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3279/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2014, 7:44 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This patch allows you to override the [general] section of logger.conf, > making it the same functionality as the [logfiles] sections. > > > Diffs > ----- > > trunk/main/logger.c 409111 > > Diff: https://reviewboard.asterisk.org/r/3279/diff/ > > > Testing > ------- > > local development. Setup > > [general] > queue_log = no > queue_log = yes > > Queue logfiles were created. > > > Thanks, > > Paul Belanger > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
