> On March 4, 2014, 1:34 p.m., Paul Belanger wrote: > > I suspect if you're submitting this change upstream, you'll need to do some > > version checks on the AMI for the API breakage. I'm not sure what will > > happen when you send asterisk a parameter it doesn't know about. But we > > still want starpy to support 1.8, 11 as long as possible. > > Scott Griepentrog wrote: > When starpy with this change is run against Asterisk without the UniqueID > changes (r/3191) the result is that the ChannelId and OtherChannelId > parameters are ignored, resulting in the previous ##########.# uniqueid > convention being used instead of the supplied Uniqud Id. An operation > requiring the unique id function for correct operation will of course fail > (i.e. you won't get the expected id in events), but otherwise I don't believe > there is any harm in allowing this patch to be used against older Asterisk > versions. > >
There isn't. Asterisk only pulls the headers it wants to parse from an AMI action, so even if StarPy sent it headers it didn't care about, it would ignore them. - Matt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3242/#review11046 ----------------------------------------------------------- On Feb. 25, 2014, 3:42 p.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3242/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2014, 3:42 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23120 > None > > > Description > ------- > > In order to test specifying the Unique Channel ID on ami.originate(), it must > know about the parameter. > > > Diffs > ----- > > > Diff: https://reviewboard.asterisk.org/r/3242/diff/ > > > Testing > ------- > > Required for https://reviewboard.asterisk.org/r/3243/ > > > File Attachments > ---------------- > > Update includes otherchannelid param > > https://reviewboard.asterisk.org/media/uploaded/files/2014/02/25/b803fe75-d355-4899-9396-66e774ed355c__starpy2.patch > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
