> On March 4, 2014, 4:45 p.m., Matt Jordan wrote: > > asterisk/trunk/tests/channels/SIP/direct_rtp_fallback/test-config.yaml, > > line 26 > > <https://reviewboard.asterisk.org/r/3297/diff/2/?file=55259#file55259line26> > > > > This seems excessive. I'd just remove it.
This is necessary to avoid a reactor timeout in the nominal case (the failure case will end at around 40 seconds) since the test must wait for a SIP dialog to be destroyed which is what actually triggered the error condition this is testing for. - opticron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3297/#review11056 ----------------------------------------------------------- On March 4, 2014, 11:30 a.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3297/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 11:30 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23310 > https://issues.asterisk.org/jira/browse/ASTERISK-23310 > > > Repository: testsuite > > > Description > ------- > > This adds a test for the scenario where Asterisk attempts to initiate a > remote RTP native bridge, but one side declines and hangs up. This could > previously cause a crash in Asterisk 1.8 and 11. > > > Diffs > ----- > > asterisk/trunk/tests/channels/SIP/tests.yaml 4745 > asterisk/trunk/tests/channels/SIP/direct_rtp_fallback/test-config.yaml > PRE-CREATION > asterisk/trunk/tests/channels/SIP/direct_rtp_fallback/sipp/uas-reinvite.xml > PRE-CREATION > > asterisk/trunk/tests/channels/SIP/direct_rtp_fallback/sipp/uas-no-reinvite.xml > PRE-CREATION > asterisk/trunk/tests/channels/SIP/direct_rtp_fallback/configs/ast1/sip.conf > PRE-CREATION > > asterisk/trunk/tests/channels/SIP/direct_rtp_fallback/configs/ast1/extensions.conf > PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3297/diff/ > > > Testing > ------- > > Verified that the indicators of the crash did not show up when running this > test and after Asterisk was patched to fix the problem. Also verified that > the indicators did show up when Asterisk was unpatched. > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
