----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3286/#review11101 -----------------------------------------------------------
Most of the same comments that apply to 3255 also apply to this review. - opticron On March 3, 2014, 2:56 p.m., Jonathan Rose wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3286/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 2:56 p.m.) > > > Review request for Asterisk Developers, Joshua Colp, Kevin Harwell, and Matt > Jordan. > > > Bugs: ASTERISK-22911 > https://issues.asterisk.org/jira/browse/ASTERISK-22911 > > > Repository: testsuite > > > Description > ------- > > Performs the same basic test as https://reviewboard.asterisk.org/r/3255/, but > uses chan_pjsip for the channel driver. > > > Diffs > ----- > > /asterisk/trunk/tests/channels/pjsip/tests.yaml 4726 > /asterisk/trunk/tests/channels/pjsip/hold_ice/test-config.yaml PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/hold_ice/sipp/phone_B.xml PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/hold_ice/sipp/phone_A.xml PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/hold_ice/sipp/inject.csv PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/hold_ice/run-test PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/hold_ice/configs/ast1/rtp.conf > PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/hold_ice/configs/ast1/pjsip.conf > PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/hold_ice/configs/ast1/extensions.conf > PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3286/diff/ > > > Testing > ------- > > Tested against Asterisk 12 revision before kharwell's initial patch for > clearing candidates was put in, got the expected crash. The patch also fails > without the current patch from https://reviewboard.asterisk.org/r/3275/ > > Everything works basically the same way as the chan_sip equivalent test does. > > > Thanks, > > Jonathan Rose > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
