-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3281/#review11077
-----------------------------------------------------------

Ship it!



/trunk/include/asterisk/devicestate.h
<https://reviewboard.asterisk.org/r/3281/#comment20725>

    Nice name :-)


- Matt Jordan


On March 4, 2014, 8:46 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3281/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 8:46 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23204
>     https://issues.asterisk.org/jira/browse/ASTERISK-23204
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> A stasis cache entry now contains more than a single message/snapshot.  It 
> contains messages/snapshots for the internal entity as well as any external 
> entities that post to the cached item.  In addition callbacks can be supplied 
> when the cache is created to compute and post the aggregate message/snapshot 
> representing all entities stored in the cache entry.
> 
> * All stasis messages now have an eid to indicate what entity posted it.
> 
> * The stasis cache enhancements allow device state to cache and aggregate the 
> device states from internal and external entities in a single operation.  The 
> cached aggregate device state is available immediately after it is posted to 
> the stasis bus.  This improves performance by eliminating a cache dump and 
> associated ao2 container traversals to calculate the aggregate state.
> 
> 
> Diffs
> -----
> 
>   /trunk/tests/test_stasis.c 409702 
>   /trunk/tests/test_devicestate.c 409702 
>   /trunk/main/stasis_message.c 409702 
>   /trunk/main/stasis_cache.c 409702 
>   /trunk/main/devicestate.c 409702 
>   /trunk/main/app.c 409702 
>   /trunk/include/asterisk/stasis.h 409702 
>   /trunk/include/asterisk/devicestate.h 409702 
> 
> Diff: https://reviewboard.asterisk.org/r/3281/diff/
> 
> 
> Testing
> -------
> 
> All unit tests pass including the stasis and device state tests.
> 
> The device state unit test had to be changed to get the aggregate state out 
> of the new cache location.  Fortunately, the normal users of the device state 
> aggregate information subscribe to the events and don't get the aggregate 
> device state out of the cache.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to