----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3288/#review11130 -----------------------------------------------------------
Ship it! This is good to go other than the minor nitpicks below. /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/resubscribe/sipp/subscribe.xml <https://reviewboard.asterisk.org/r/3288/#comment20787> These can be combined into: <Reference variables="substate,resubstate" /> /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unsubscribe/unsubscribe.py <https://reviewboard.asterisk.org/r/3288/#comment20788> This import is unnecessary. - opticron On March 7, 2014, 8:45 a.m., jbigelow wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3288/ > ----------------------------------------------------------- > > (Updated March 7, 2014, 8:45 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23344 > https://issues.asterisk.org/jira/browse/ASTERISK-23344 > > > Repository: testsuite > > > Description > ------- > > These tests cover re-subscribe and un-subscribe for presence using PJSIP. > > Note: This review request also re-organizes existing subscription tests. > > Tests: > * unsubscribe - Nominal test using the pjsua pluggable module where "alice" > subscribes to "bob. Alice then un-subscribes (expiration of '0') and the pass > result is set based upon the subscription state being reported as terminated. > Otherwise the fail result is set. > > * resubscribe - Nominal test that uses SIPp (aka. "alice") to subscribe to > "bob" with an expiration of 300. Upon successfully subscribing, alice then > subscribes to bob again but with an expiration of 600. This ensures the > re-subscribe is successful per receiving a 200 response and a Notify with the > expected expiration in the Subscription-State header. > > > Diffs > ----- > > /asterisk/trunk/tests/channels/pjsip/tests.yaml 4799 > /asterisk/trunk/tests/channels/pjsip/subscriptions/tests.yaml PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unsubscribe/unsubscribe.py > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unsubscribe/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unsubscribe/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unsubscribe/configs/ast1/modules.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unsubscribe/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/tests.yaml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/resubscribe/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/resubscribe/sipp/subscribe.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/resubscribe/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/resubscribe/configs/ast1/modules.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/resubscribe/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/tests.yaml > PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/subscribe/tests.yaml 4799 > /asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/test-config.yaml > 4799 > > /asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/sipp/subscribe.xml > 4799 > /asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/run-test 4799 > > /asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/configs/ast1/pjsip.conf > 4799 > > /asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/configs/ast1/modules.conf > 4799 > > /asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/test-config.yaml > 4799 > > /asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/sipp/subscribe.xml > 4799 > /asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/run-test > 4799 > > /asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/configs/ast1/pjsip.conf > 4799 > > /asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/configs/ast1/extensions.conf > 4799 > /asterisk/trunk/tests/channels/pjsip/presence_xpidf/test-config.yaml 4799 > /asterisk/trunk/tests/channels/pjsip/presence_xpidf/state_check.py 4799 > /asterisk/trunk/tests/channels/pjsip/presence_xpidf/configs/ast1/pjsip.conf > 4799 > > /asterisk/trunk/tests/channels/pjsip/presence_xpidf/configs/ast1/modules.conf > 4799 > > /asterisk/trunk/tests/channels/pjsip/presence_xpidf/configs/ast1/extensions.conf > 4799 > /asterisk/trunk/tests/channels/pjsip/presence_pidf/test-config.yaml 4799 > /asterisk/trunk/tests/channels/pjsip/presence_pidf/state_check.py 4799 > /asterisk/trunk/tests/channels/pjsip/presence_pidf/configs/ast1/pjsip.conf > 4799 > > /asterisk/trunk/tests/channels/pjsip/presence_pidf/configs/ast1/modules.conf > 4799 > > /asterisk/trunk/tests/channels/pjsip/presence_pidf/configs/ast1/extensions.conf > 4799 > /asterisk/trunk/tests/channels/pjsip/mwi_aggregate/test-config.yaml 4799 > /asterisk/trunk/tests/channels/pjsip/mwi_aggregate/mwi_check.py 4799 > /asterisk/trunk/tests/channels/pjsip/mwi_aggregate/configs/ast1/pjsip.conf > 4799 > > /asterisk/trunk/tests/channels/pjsip/mwi_aggregate/configs/ast1/modules.conf > 4799 > /asterisk/trunk/tests/channels/pjsip/mwi/test-config.yaml 4799 > /asterisk/trunk/tests/channels/pjsip/mwi/mwi_check.py 4799 > /asterisk/trunk/tests/channels/pjsip/mwi/configs/ast1/pjsip.conf 4799 > /asterisk/trunk/tests/channels/pjsip/mwi/configs/ast1/modules.conf 4799 > > Diff: https://reviewboard.asterisk.org/r/3288/diff/ > > > Testing > ------- > > * Ensured tests pass on multiple executions > * Ensured the testsuite & Asterisk logs looked good. > > > Thanks, > > jbigelow > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
