----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3314/#review11148 -----------------------------------------------------------
./asterisk/trunk/tests/apps/bridge/bridge_wait/bridge_wait_s_option/configs/ast1/extensions.conf <https://reviewboard.asterisk.org/r/3314/#comment20792> As a nitpick, we don't typically uppercase extensions or contexts. I'd use snake_case for any context/extension/priority_label in the dialplan. [holding] exten => bridge_holding,1,NoOp() ./asterisk/trunk/tests/apps/bridge/bridge_wait/bridge_wait_s_option/test-config.yaml <https://reviewboard.asterisk.org/r/3314/#comment20793> Rename this to: Local/bridge_holding@holding Make sure you update the other references as appropriate - Matt Jordan On March 6, 2014, 2:42 p.m., Scott Emidy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3314/ > ----------------------------------------------------------- > > (Updated March 6, 2014, 2:42 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23354 > https://issues.asterisk.org/jira/browse/ASTERISK-23354 > > > Repository: testsuite > > > Description > ------- > > The test was to join a holding bridge using the BridgeWait application, and > use the S option in order to exit the holding bridge after 5 seconds. As long > as the time was between 3 to 7 seconds the test still passes. > > > Diffs > ----- > > ./asterisk/trunk/tests/apps/bridge/tests.yaml 4765 > ./asterisk/trunk/tests/apps/bridge/bridge_wait/tests.yaml PRE-CREATION > > ./asterisk/trunk/tests/apps/bridge/bridge_wait/bridge_wait_s_option/test-config.yaml > PRE-CREATION > > ./asterisk/trunk/tests/apps/bridge/bridge_wait/bridge_wait_s_option/configs/ast1/extensions.conf > PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3314/diff/ > > > Testing > ------- > > > Thanks, > > Scott Emidy > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
