----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3331/#review11167 -----------------------------------------------------------
/trunk/apps/app_chanspy.c <https://reviewboard.asterisk.org/r/3331/#comment20802> There's no need to assign 0 to bridge_connected here, as you already initialized it to 0 previously. /trunk/apps/app_chanspy.c <https://reviewboard.asterisk.org/r/3331/#comment20803> Since the act of re-attaching the channel in barge mode uses the same code as the initial attachment, this could be refactored to place the act of attaching in a separate function. Said function could return 0 on success or 1 on failure, which could be used to indicate whether or not the barger was previously attached. /trunk/apps/app_chanspy.c <https://reviewboard.asterisk.org/r/3331/#comment20801> Coding guidelines: if (!bridge_connected) instead of: if(bridge_connected == 0) The space is necessary. Testing for negation using '!' is generally preferred over an explicit value. - Matt Jordan On March 11, 2014, 6:23 p.m., Robert Moss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3331/ > ----------------------------------------------------------- > > (Updated March 11, 2014, 6:23 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23381 > https://issues.asterisk.org/jira/browse/ASTERISK-23381 > > > Repository: Asterisk > > > Description > ------- > > Chanspy now can whisper to the spyee's "bridged party" (callee) (aka barging) > even if the Spy started before the bridged party answered. > > > Diffs > ----- > > /trunk/apps/app_chanspy.c 410469 > > Diff: https://reviewboard.asterisk.org/r/3331/diff/ > > > Testing > ------- > > Chanspy on an extension while the spyee's call is still ringing, after the > bridged party answers, both spied on parties can hear the monitor. > > > Thanks, > > Robert Moss > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
