> On March 13, 2014, 2:21 p.m., Matt Jordan wrote: > > Before this patch goes any further, it needs adequate testing. > > > > While posting a patch with 'it compiles' is a bare minimum requirement, for > > it to be included seriously for inclusion the "How this was tested" field > > should be filled in such that there is some confidence that the patch fixes > > the reported problem.
Got it. That's why I put the explicit comment - to ensure someone interested at this issue will give it a try and report back. - zvision ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3346/#review11166 ----------------------------------------------------------- On March 13, 2014, 10:06 a.m., zvision wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3346/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 10:06 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23351 > https://issues.asterisk.org/jira/browse/ASTERISK-23351 > > > Repository: Asterisk > > > Description > ------- > > This patch fixes handling of nullable int columns in update_realtime > function. It checks if a value is empty and sets the column to NULL instead > of '', which raises an error. > Additionally, it checks for existence of the keyfield column instead of the > first parameter column. > > > Diffs > ----- > > http://svn.asterisk.org/svn/asterisk/branches/11/res/res_config_pgsql.c > 410508 > > Diff: https://reviewboard.asterisk.org/r/3346/diff/ > > > Testing > ------- > > Only tested for successful compilation. Someone needs to confirm that the > patch works fine. > > > Thanks, > > zvision > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
