----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3325/#review11179 -----------------------------------------------------------
Ship it! My only issues are with documentation. Otherwise, it's good to go. /branches/12/include/asterisk/app.h <https://reviewboard.asterisk.org/r/3325/#comment20820> Mailbox is not necessarily a number. It can be any string. (same comment applies to the doxygen for mwi_state_create_message() in app.c) /branches/12/main/app.c <https://reviewboard.asterisk.org/r/3325/#comment20819> Description is incomplete. - Mark Michelson On March 10, 2014, 9:24 p.m., rmudgett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3325/ > ----------------------------------------------------------- > > (Updated March 10, 2014, 9:24 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > One of the things missing when external MWI support was added was the ability > to clear the stasis cache entry of deleted external MWI mailboxes. > > > Diffs > ----- > > /branches/12/res/res_mwi_external.c 410444 > /branches/12/main/app.c 410444 > /branches/12/include/asterisk/app.h 410444 > > Diff: https://reviewboard.asterisk.org/r/3325/diff/ > > > Testing > ------- > > Added temporary debug messages and observed that the stasis cache entry was > removed when the external MWI mailbox was deleted. > > > Thanks, > > rmudgett > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
