> On March 13, 2014, 6:13 p.m., Mark Michelson wrote: > > One thing I notice about this test is that it is structured to call the > > first extension, then when that finishes, call the second, then when that > > finishes, call the third, etc. > > > > Since no call depends on any of the previous call results, I think this > > test could be changed to originate all the calls at the same time and > > evaluate the UserEvents and Hangups as they arrive. This would have a few > > benefits: > > > > 1) The test will execute more quickly > > 2) You can get rid of the can_call member of your test class. > > 3) Your AMI hangup handler will be simplified greatly since you won't need > > to have a big if-else ladder to figure out what to do next. In fact, you > > may be able to just get rid of it altogether. > > > > Doing it this way kind of screws up your detected member, though. As a > > simple workaround, in your new_exten_event_handler, you can determine > > whether to send the AMI hangup by checking event['AppData'] for the name of > > the AGI script. If event['AppData'] is 'waiting.agi' or 'executing.agi' > > then you issue the AMI hangup.
Doing tests serially allows them to be debugged easier. Having all the tests run simultaneously makes it difficult to figure out which event is a result of which test. This is especially true if unexpected events happen that are a clue to what is going wrong. - rmudgett ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3329/#review11196 ----------------------------------------------------------- On March 11, 2014, 2:54 p.m., Benjamin Keith Ford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3329/ > ----------------------------------------------------------- > > (Updated March 11, 2014, 2:54 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-19167 > https://issues.asterisk.org/jira/browse/ASTERISK-19167 > > > Repository: testsuite > > > Description > ------- > > Notes: > - Is a sub-task of ASTERISK-19167 > - Ignore userA directory; will be removed from repository > > This test runs through a few different AGI scripts to verify that AGISTATUS > returns the correct values: > 1. Attempts to run an AGI script that does not exist. AGISTATUS returns > NOTFOUND. > 2. Attempts to run an AGI script that has an invalid path. AGISTATUS returns > FAILURE. > 3. Attempts to run an AGI script that has a non-executable interpreter. > AGISTATUS returns FAILURE. > 4. Attempts to run an AGI script that is non-executable. AGISTATUS returns > FAILURE. > 5. Runs an AGI script that will be hung up on while waiting for a command. > AGISTATUS returns HANGUP. > 6. Runs an AGI script that will be hung up on while executing a command. > AGISTATUS returns HANGUP. > 7. Runs an AGI script that exits normally. AGISTATUS returns SUCCESS. > > > Diffs > ----- > > ./asterisk/trunk/tests/agi/exit_status/waiting.agi PRE-CREATION > ./asterisk/trunk/tests/agi/exit_status/test-config.yaml 4749 > ./asterisk/trunk/tests/agi/exit_status/run-test 4749 > ./asterisk/trunk/tests/agi/exit_status/executing.agi PRE-CREATION > ./asterisk/trunk/tests/agi/exit_status/donothing.agi PRE-CREATION > ./asterisk/trunk/tests/agi/exit_status/configs/ast1/extensions.conf > PRE-CREATION > ./asterisk/trunk/tests/agi/exit_status/badinterpreter3.agi PRE-CREATION > ./asterisk/trunk/tests/agi/exit_status/badinterpreter2.agi PRE-CREATION > ./asterisk/trunk/tests/agi/exit_status/badinterpreter.agi PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3329/diff/ > > > Testing > ------- > > > Thanks, > > Benjamin Keith Ford > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
