----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3373/#review11283 -----------------------------------------------------------
Ship it! Ship It! - rmudgett On March 18, 2014, 12:43 p.m., Jonathan Rose wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3373/ > ----------------------------------------------------------- > > (Updated March 18, 2014, 12:43 p.m.) > > > Review request for Asterisk Developers, Matt Jordan and rmudgett. > > > Bugs: ASTERISK-23461 > https://issues.asterisk.org/jira/browse/ASTERISK-23461 > > > Repository: Asterisk > > > Description > ------- > > Long story short, the mute flag is raised after the conference user is joined > to the conference bridge. During the join, the user's mute flag (which is > still unraised at this point) is checked to determine initial mute status. > The first user appears to work because a second update occurs on it when a > second user joins (this can be broken by having the second user join while > the first user is still in the process of joining). > > This patch fixes all of that simply by setting the muted flag prior to > joining. > > > Diffs > ----- > > /branches/11/apps/app_confbridge.c 410862 > > Diff: https://reviewboard.asterisk.org/r/3373/diff/ > > > Testing > ------- > > Tested joining with 1, 2, and 3 participants. Checked practical mute status > (IE who hears what) and stated mute status in each condition from 1 > participant to 3 participants. > > I'm also currently writing a testsuite test. > > > Thanks, > > Jonathan Rose > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
