----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3375/#review11331 -----------------------------------------------------------
Looks pretty much good to go. A few remarks below. And a last chance for people to have an opinion about making this the default (and unchangeable) behaviour in Asterisk 13. http://svn.asterisk.org/svn/asterisk/branches/11/configs/res_odbc.conf.sample <https://reviewboard.asterisk.org/r/3375/#comment20973> + NOTE: This option will be removed in asterisk 13. At that point, it will always behave as if it was set to 'no'. http://svn.asterisk.org/svn/asterisk/branches/11/res/res_config_odbc.c <https://reviewboard.asterisk.org/r/3375/#comment20975> Please move the (non-inline) ast_odbc function call to the back so we can avoid the call for char-columns. Also, we don't need to check tableptr, since column would be NULL if it was false. http://svn.asterisk.org/svn/asterisk/branches/11/res/res_config_odbc.c <https://reviewboard.asterisk.org/r/3375/#comment20974> + /* Value is non-zero, or column accepts empty strings, or we couldn't fit any more into cps.skip (count>63 ?!). */ (Yes, that's the reason for the seemingly random 64.) - wdoekes On March 18, 2014, 11:05 p.m., zvision wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3375/ > ----------------------------------------------------------- > > (Updated March 18, 2014, 11:05 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23459 > https://issues.asterisk.org/jira/browse/ASTERISK-23459 > > > Repository: Asterisk > > > Description > ------- > > This review request is a patch for the issue reviewed in > https://reviewboard.asterisk.org/r/3335 but for non-trunk versions. > > Changes: > - correct check for keyfield existence, > - new res_odbc.conf variable allow_empty_string_in_nontext, > - proper empty string => NULL conversion with allow_empty_string_in_nontext > option disabled > for non-text columns. > > This patch is based on branch 11 svn, but code for 1.8 and 10 is the same, so > it should apply with no problems. > > > Diffs > ----- > > http://svn.asterisk.org/svn/asterisk/branches/11/res/res_odbc.exports.in > 410875 > http://svn.asterisk.org/svn/asterisk/branches/11/res/res_odbc.c 410875 > http://svn.asterisk.org/svn/asterisk/branches/11/res/res_config_odbc.c > 410875 > > http://svn.asterisk.org/svn/asterisk/branches/11/include/asterisk/res_odbc.h > 410875 > > http://svn.asterisk.org/svn/asterisk/branches/11/configs/res_odbc.conf.sample > 410875 > > Diff: https://reviewboard.asterisk.org/r/3375/diff/ > > > Testing > ------- > > Tested with Asterisk 11 + ODBC + SIP realtime + PostgreSQL with both > allow_empty_string_in_nontext settings > to ensure no regression is introduced. > > > Thanks, > > zvision > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
