----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3392/#review11372 -----------------------------------------------------------
Ship it! Only thing I found was a minor nitpick. Otherwise, it looks good to me. ./asterisk/trunk/tests/channels/pjsip/headers/test-config.yaml <https://reviewboard.asterisk.org/r/3392/#comment21020> These two scenarios don't need '-d': '3000' since they do not have any <pause /> elements in them. - Mark Michelson On March 25, 2014, 3:27 p.m., Benjamin Keith Ford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3392/ > ----------------------------------------------------------- > > (Updated March 25, 2014, 3:27 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23453 > https://issues.asterisk.org/jira/browse/ASTERISK-23453 > > > Repository: testsuite > > > Description > ------- > > This test covers two different scenarios: reading the headers on an inbound > call, and reading/modifying the headers on an outbound call. > > - On the inbound call, a standard header is read, as well as a custom header. > > - On the outbound call, a standard header is read, as well as a custom > header. Custom headers are added to the SIP packet, modified, and removed. > > > Diffs > ----- > > ./asterisk/trunk/tests/channels/pjsip/tests.yaml 4836 > ./asterisk/trunk/tests/channels/pjsip/headers/test-config.yaml PRE-CREATION > > ./asterisk/trunk/tests/channels/pjsip/headers/sipp/outbound-recv-headers.xml > PRE-CREATION > ./asterisk/trunk/tests/channels/pjsip/headers/sipp/outbound-headers.xml > PRE-CREATION > ./asterisk/trunk/tests/channels/pjsip/headers/sipp/inbound-headers.xml > PRE-CREATION > ./asterisk/trunk/tests/channels/pjsip/headers/configs/ast1/pjsip.conf > PRE-CREATION > ./asterisk/trunk/tests/channels/pjsip/headers/configs/ast1/extensions.conf > PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3392/diff/ > > > Testing > ------- > > > Thanks, > > Benjamin Keith Ford > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
