----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3320/#review11456 -----------------------------------------------------------
Ship it! A couple of nits that may not need to even be changed. /team/group/media_formats-reviewed/formats/format_pcm.c <https://reviewboard.asterisk.org/r/3320/#comment21149> Maybe use ast_format_cmp here to be consistent with the other changes and if ast_format_cmp ever change this will be picked up. /team/group/media_formats-reviewed/formats/format_pcm.c <https://reviewboard.asterisk.org/r/3320/#comment21148> Another spot to use ast_format_cmp. - Kevin Harwell On March 20, 2014, 6:39 a.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3320/ > ----------------------------------------------------------- > > (Updated March 20, 2014, 6:39 a.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This change moves format modules over to the new media formats API. Some > duplicated code was removed as it will be consolidated in the core. > > > Diffs > ----- > > /team/group/media_formats-reviewed/formats/format_wav_gsm.c 409286 > /team/group/media_formats-reviewed/formats/format_wav.c 409286 > /team/group/media_formats-reviewed/formats/format_vox.c 409286 > /team/group/media_formats-reviewed/formats/format_sln.c 409286 > /team/group/media_formats-reviewed/formats/format_siren7.c 409286 > /team/group/media_formats-reviewed/formats/format_siren14.c 409286 > /team/group/media_formats-reviewed/formats/format_pcm.c 409286 > /team/group/media_formats-reviewed/formats/format_ogg_vorbis.c 409286 > /team/group/media_formats-reviewed/formats/format_jpeg.c 409286 > /team/group/media_formats-reviewed/formats/format_ilbc.c 409286 > /team/group/media_formats-reviewed/formats/format_h264.c 409286 > /team/group/media_formats-reviewed/formats/format_h263.c 409286 > /team/group/media_formats-reviewed/formats/format_gsm.c 409286 > /team/group/media_formats-reviewed/formats/format_g729.c 409286 > /team/group/media_formats-reviewed/formats/format_g726.c 409286 > /team/group/media_formats-reviewed/formats/format_g723.c 409286 > /team/group/media_formats-reviewed/formats/format_g719.c 409286 > > Diff: https://reviewboard.asterisk.org/r/3320/diff/ > > > Testing > ------- > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
