----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3421/#review11661 -----------------------------------------------------------
Ship it! Ship It! - opticron On April 4, 2014, 8:46 p.m., rmudgett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3421/ > ----------------------------------------------------------- > > (Updated April 4, 2014, 8:46 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > * Restore the reason value set by pbx_outgoing_attempt() to use > AST_CONTROL_xxx values as all the consumers were expecting rather than cause > codes. > > * Fixed the dial routines to set cause codes for more than just ast_request() > so pbx_outgoing_attempt() reason codes will function. > > * Fix inconsistent locked_channel return status in pbx_outgoing_attempt(). > The chanel may not have been locked or the channel may have been a stale > pointer. > > * Fixed the OutgoingSpoolFailed channel to run dialplan whenever the dialing > fails for an originate exten and 1 < synchronous. > > * Fix incorrect ast_cond_wait() usage in pbx_outgoing_attempt(). Indroduced > by issue ASTERISK-22212 patch. > > * Made struct pbx_outgoing use the ao2 lock instead of its own lock for the > cond wait mutex. No sense in having two locks associated with the same > struct when only one is needed. > > > Diffs > ----- > > /branches/12/main/pbx.c 411766 > /branches/12/main/dial.c 411766 > /branches/12/include/asterisk/pbx.h 411766 > /branches/12/apps/app_originate.c 411766 > > Diff: https://reviewboard.asterisk.org/r/3421/diff/ > > > Testing > ------- > > Did an AMI originate to a Local/busy@context that has the Busy application > and got expected AST_CONTROL_BUSY code. > Did an AMI originate to a Local/congestion@context that has the Congestion > application and got expected AST_CONTROL_CONTESTED code. > Did an AMI originate to an exten that didn't answer within the timeout and > got the AST_CONTROL_RINGING code as previous versions of Asterisk return. > Did an AMI originate to an exten that answered and got the > AST_CONTROL_ANSWERED code. > Did an AMI originate to a DAHDI channel that is busy and got the > AST_CONTROL_BUSY code. (chan_dahdi ast_request() does not create the channel > like other channel drivers in this case) > Did an AMI originate to a DAHDI group that has no members available and got > the AST_CONTROL_CONGESTED code. > > > Thanks, > > rmudgett > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
