----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3443/#review11705 -----------------------------------------------------------
It looks like these patches were merely attached to the review board posting, as opposed to being uploaded using post-review or uploaded directly as a diff. That makes it very hard to review. Please review the instructions for using Review Board (https://wiki.asterisk.org/wiki/display/AST/Review+Board+Usage) and post the diffs so that they show up as code to be reviewed. - Matt Jordan On April 14, 2014, 12:34 a.m., Kevin McCoy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3443/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 12:34 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: https://issues.asterisk.org/jira/browse/ASTERISK-23324 > None > > > Description > ------- > > Japanese language support patch for sound files in app_voicemail.c and say.c, > depends on entire sound file package currently available in release candidate > format as per https://issues.asterisk.org/jira/browse/ASTERISK-23324 > https://www.dropbox.com/s/axu6gfnf9fh40hz/asterisk-core-sounds-ja-wav-and-patch.tgz > > Word order and plurals, dates, counts in Japanese are all significantly > different than English, hence the need for this patch. Tested working with > Asterisk 12. > > Here is the installation procedure from the README contained in the RC > archive: > > ---------- > > > Install Asterisk Sound Files: > mkdir /var/lib/asterisk/sounds/ja > cd /var/lib/asterisk/sounds/ja > wget > http://downloads.asterisk.org/pub/telephony/sounds/asterisk-core-sounds-ja-gsm-current.tar.gz > > tar xvfz asterisk-core-sounds-ja-gsm-current.tar.gz > rm -f asterisk-core-sounds-ja-gsm-current.tar.gz > chown -R asterisk.asterisk /var/lib/asterisk/sounds/ja > > How To Change Default SIP Channel Language to Japanese > > Using Asterisk (vanilla): > vi /etc/asterisk/sip.conf > Edit language variable to: > language = ja > > Using FreePBX: > On the FreePBX menu -> Settings -> Asterisk SIP Settings -> Advanced General > Settings section -> Language field > Set Language field to : ja > > Install Japanese Patch: > Download Asterisk 12 source > Change directory to Asterisk 12 source folder > Download the patches for say.c and app_voicemail.c > patch -p0 < say.c.20140226.jp.patch > patch -p0 < app_voicemail.c.20140226.jp.patch > Compile Asterisk 12 source as usual > > > ------ > > I'm happy to answer questions about the code. > > > Diffs > ----- > > > Diff: https://reviewboard.asterisk.org/r/3443/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > app_voicemail.c.20140226.jp.patch > > https://reviewboard.asterisk.org/media/uploaded/files/2014/04/14/cfe35d8c-066d-4b69-9f52-8e104f8b3770__app_voicemail.c.20140226.jp.patch > say.c.20140226.jp.patch > > https://reviewboard.asterisk.org/media/uploaded/files/2014/04/14/2f6dd68b-7549-48d8-8750-e043202f41f5__say.c.20140226.jp.patch > > > Thanks, > > Kevin McCoy > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
