----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/1803/#review11713 -----------------------------------------------------------
Unless anyone objects, I'm going to move that we close this review as being subsumed by r3447 (https://reviewboard.asterisk.org/r/3447/). - Matt Jordan On March 13, 2012, 1:33 a.m., jamicque wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/1803/ > ----------------------------------------------------------- > > (Updated March 13, 2012, 1:33 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-19465 > https://issues.asterisk.org/jira/browse/ASTERISK-19465 > > > Repository: Asterisk > > > Description > ------- > > It seams that in Asterisk privacy with PAI is not implemented correctly. > > According to RFC 3325 when using privacy, PAI header should be set to caller > num and name. The privacy is implemented by adding privacy: id header. > Now when we use pai and callpres=prohib in P-Asserted-Identity header we have > something which is not correct to any rfc. > P-Asserted-Identity: "Anonymous" <sip:[email protected]> > > What my patch does: > 1) adds new configurable parameter for peer - trustpeer (whether we should > send privacy information to peer or not) > 2) it adds Privacy header to trusted peer when PAI and CLIR is used (values > "id") > 3) When PAI or RPID with CLIR is used and fromuser is set it is often used > for authentication/recognition of the peer on the other side so we set the > proper domain (not anonymous.invalid) > > > Diffs > ----- > > /trunk/configs/sip.conf.sample 358608 > /trunk/channels/sip/include/sip.h 358575 > /trunk/channels/chan_sip.c 358575 > > Diff: https://reviewboard.asterisk.org/r/1803/diff/ > > > Testing > ------- > > I've done some basing test with outgoing calls and everything seems to works > fine. > > > Thanks, > > jamicque > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
