----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3476/#review11739 -----------------------------------------------------------
./asterisk/trunk/lib/python/asterisk/memory_test_condition.py <https://reviewboard.asterisk.org/r/3476/#comment21532> Why math.fabs() and not just abs() ? Aren't you dealing with integers here? I don't share Marks fear that decreasing memory usage would create false positives. If that were to be an issue, we can always go back and alter the test. ./asterisk/trunk/lib/python/asterisk/memory_test_condition.py <https://reviewboard.asterisk.org/r/3476/#comment21533> E128: You want to line these up past the parenthesis: x = (abc, def) - wdoekes On April 24, 2014, 7:02 p.m., Benjamin Keith Ford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3476/ > ----------------------------------------------------------- > > (Updated April 24, 2014, 7:02 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-18429 > https://issues.asterisk.org/jira/browse/ASTERISK-18429 > > > Repository: testsuite > > > Description > ------- > > This testcondition can be enabled for any test using the keyword 'memory' > under testconditions. The purpose of this testcondition is to check the > memory allocated before and after the test, and make sure they are within a > certain range. If the test wants to look at something specific (such as > channel.c), then each allocation that you want to look at can also be > specified in under 'allocations'. If both the global memory and individual > allocations are to be checked by the test, that option can be enabled by > setting 'both' to value True. > > > Diffs > ----- > > ./asterisk/trunk/test-config.yaml 4944 > ./asterisk/trunk/lib/python/asterisk/test_conditions.py 4944 > ./asterisk/trunk/lib/python/asterisk/test_case.py 4944 > ./asterisk/trunk/lib/python/asterisk/memory_test_condition.py PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3476/diff/ > > > Testing > ------- > > > Thanks, > > Benjamin Keith Ford > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
