-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3073/
-----------------------------------------------------------
(Updated May 1, 2014, 12:53 p.m.)
Review request for Asterisk Developers.
Changes
-------
Thanks for the review. Sorry for the delay.
/* Check if we're in ring state */
if (replacecall->_state == AST_STATE_RING)
earlyreplace = 1;
In our case, the state is AST_STATE_RINGING, so earlyreplace is 0, but
oneleggedreplace is 1.
So I altered the patch to do:
if (earlyreplace || oneleggedreplace) {
Bugs: ASTERISK-22977
https://issues.asterisk.org/jira/browse/ASTERISK-22977
Repository: Asterisk
Description
-------
To make a long story short:
- When doing a "BLF-style call pickup" -- an INVITE with Replaces: header --
the CEL log would be missing an ANSWER en PICKUP event.
- This goes unnoticed when you use Asterisk only, because chan_sip cheats when
sending out NOTIFYs. Only when you rely on something else to send out the
NOTIFYs (e.g. *SER pua_dialoginfo) does this problem occur.
This patch adds the two missing events to the handle_invite_replaces() function.
Long explanation is in the referenced ticket.
Diffs (updated)
-----
/branches/1.8/channels/chan_sip.c 413160
Diff: https://reviewboard.asterisk.org/r/3073/diff/
Testing
-------
Tested against 11, but issue is present in 1.8 as well. Test results are
reported in ticket. Breaks down to: for my scenario it works, the two missing
events are not missing anymore.
One question: are there other uses of handle_invite_replaces() that should not
get these events?
Thanks,
wdoekes
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
