----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3388/#review11853 -----------------------------------------------------------
/team/group/media_formats-reviewed/channels/chan_mgcp.c <https://reviewboard.asterisk.org/r/3388/#comment21723> I'd declare these on separate lines. Just a thought. /team/group/media_formats-reviewed/channels/chan_mgcp.c <https://reviewboard.asterisk.org/r/3388/#comment21724> I enjoy this comment, because I have no reference for what it means... but you've kept the comment. Excellent. /team/group/media_formats-reviewed/channels/chan_skinny.c <https://reviewboard.asterisk.org/r/3388/#comment21725> I'm not sure we can just remove this from chan_skinny :-) If it's not currently possible to print out the codec preference order in some fashion, we should at least put in a BUGBUG to come back and add this when there's an API call for it. /team/group/media_formats-reviewed/channels/chan_skinny.c <https://reviewboard.asterisk.org/r/3388/#comment21726> Add BUGBUG for this as well - Matt Jordan On May 5, 2014, 6:11 a.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3388/ > ----------------------------------------------------------- > > (Updated May 5, 2014, 6:11 a.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This moves the chan_mgcp, chan_unistim, and chan_skinny modules over to the > media formats API. > > > Diffs > ----- > > /team/group/media_formats-reviewed/include/asterisk/format_cache.h 413300 > /team/group/media_formats-reviewed/channels/chan_unistim.c 413300 > /team/group/media_formats-reviewed/channels/chan_skinny.c 413300 > /team/group/media_formats-reviewed/channels/chan_mgcp.c 413300 > > Diff: https://reviewboard.asterisk.org/r/3388/diff/ > > > Testing > ------- > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
