----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3485/#review11927 -----------------------------------------------------------
/branches/12/include/asterisk/bridge.h <https://reviewboard.asterisk.org/r/3485/#comment21821> This should be documented more since it's now a wrapper. Are there any expectations? Should it be allocated in any specific way? In the case of res_pjsip_refer it expects this as an AO2 object, but that's currently an implementation detail of the blind transfer/parking code that is not documented. Could your stack usage of this be passed into the announcement tracker and hilarity ensue? /branches/12/include/asterisk/bridge.h <https://reviewboard.asterisk.org/r/3485/#comment21819> I also don't think "ready" is appropriate here. "completed" would be better since the transfer operation has fully completed when it is set. /branches/12/include/asterisk/parking.h <https://reviewboard.asterisk.org/r/3485/#comment21820> You're adding this so make the name right. parked_channel_data. This applies to elsewhere too. /branches/12/res/parking/parking_bridge_features.c <https://reviewboard.asterisk.org/r/3485/#comment21823> What value does this add over just using transfer_channel_data directly? /branches/12/res/parking/parking_bridge_features.c <https://reviewboard.asterisk.org/r/3485/#comment21824> Add some documentation that this stasis message handling will block if it is tracking the announcement. This could be important in the future if how message dispatch occurs changes. /branches/12/res/res_pjsip_refer.c <https://reviewboard.asterisk.org/r/3485/#comment21822> Can you further elaborate on this? Why did you add this? What problem was there? What does it solve? - Joshua Colp On May 19, 2014, 6:25 p.m., Jonathan Rose wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3485/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 6:25 p.m.) > > > Review request for Asterisk Developers, Matt Jordan and Mark Michelson. > > > Repository: Asterisk > > > Description > ------- > > If a PJSIP endpoint attempts to blind transfer to a parking extension, there > is an override to the normal transfer logic that can make things act a little > weird. We noticed that this would leave various phones hanging on transfer > screens without progressing. When the transfer was considered successful, > PJSIP deferred the actual action of sending the 200 notify and the actual > trigger for that happening never occurs when the transfer is to a parking > extension. > > In order to handle this, the bridge function that handles blind transfers now > returns a different value if a call was parked and if the channel driver > needs to react differently in this case, it can. In the case of PJSIP, we > respond to transfers to park by immediately sending the notify with 200 OK > sip frag instead of deferring the action. > > > Diffs > ----- > > /branches/12/res/res_pjsip_refer.c 413303 > /branches/12/res/parking/parking_bridge_features.c 413303 > /branches/12/res/parking/parking_applications.c 413303 > /branches/12/main/parking.c 413303 > /branches/12/main/bridge_basic.c 413303 > /branches/12/main/bridge.c 413303 > /branches/12/include/asterisk/parking.h 413303 > /branches/12/include/asterisk/bridge.h 413303 > /branches/12/channels/sig_analog.c 413303 > /branches/12/channels/chan_sip.c 413303 > /branches/12/channels/chan_mgcp.c 413303 > /branches/12/channels/chan_dahdi.c 413303 > > Diff: https://reviewboard.asterisk.org/r/3485/diff/ > > > Testing > ------- > > Before patch: > * Blind transfer on Polycom SPIP: Phone is on the blind transfer screen until > it either manually hangs up or 60 seconds pass and Asterisk terminates the > session. > > After the patch: > * Blind transfer on Polycom SPIP: Phone immediately leaves the blind transfer > screen and goes back to idle mode. > > > Thanks, > > Jonathan Rose > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
