----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3567/#review11968 -----------------------------------------------------------
/tags/11.9.0/channels/chan_unistim.c <https://reviewboard.asterisk.org/r/3567/#comment21880> How about simply moving the unlock up 4 lines. One unlock is better than two. Furthermore, we generally patch the branches, not the tags. (Tags are immutable by convention.) You should patch /branches/11. - wdoekes On May 27, 2014, 8:32 a.m., Peter Whisker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3567/ > ----------------------------------------------------------- > > (Updated May 27, 2014, 8:32 a.m.) > > > Review request for Asterisk Developers and Igor Goncharovsky. > > > Bugs: ASTERISK-23792 > https://issues.asterisk.org/jira/browse/ASTERISK-23792 > > > Repository: Asterisk > > > Description > ------- > > There is a conditional exit from a mutexed area of code which does not unlock > before the return. > > > Diffs > ----- > > /tags/11.9.0/channels/chan_unistim.c 414555 > > Diff: https://reviewboard.asterisk.org/r/3567/diff/ > > > Testing > ------- > > Inspection and build > > > Thanks, > > Peter Whisker > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
