----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3561/#review11971 -----------------------------------------------------------
Ship it! Ship It! - Matt Jordan On May 22, 2014, 5:19 p.m., rmudgett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3561/ > ----------------------------------------------------------- > > (Updated May 22, 2014, 5:19 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23499 > https://issues.asterisk.org/jira/browse/ASTERISK-23499 > > > Repository: testsuite > > > Description > ------- > > * Fixed the agent_acknowledge_error test scenerio 1 that could never fail. > The test can fail now if you actually send the expected DTMF digit. > > * Cleaned up the extensions.conf spacing and added Answer() and Hangup() > where needed. > > * Added "NoOp(AGENT_STATUS is ${AGENT_STATUS})" after AgentLogin() and > AgentRequest() to log the value if those applicaitons happen to continue in > the dialplan. > > * Cleaned up most test-config.yaml tests to order the events and calls in the > order they are expected. > > > Diffs > ----- > > /asterisk/trunk/tests/apps/agents/agent_request/nominal/test-config.yaml > 5053 > > /asterisk/trunk/tests/apps/agents/agent_request/nominal/configs/ast1/extensions.conf > 5053 > /asterisk/trunk/tests/apps/agents/agent_login/nominal/test-config.yaml 5053 > > /asterisk/trunk/tests/apps/agents/agent_login/nominal/configs/ast1/extensions.conf > 5053 > /asterisk/trunk/tests/apps/agents/agent_login/login_errors/test-config.yaml > 5053 > > /asterisk/trunk/tests/apps/agents/agent_login/login_errors/configs/ast1/extensions.conf > 5053 > > /asterisk/trunk/tests/apps/agents/agent_acknowledge/nominal/test-config.yaml > 5053 > > /asterisk/trunk/tests/apps/agents/agent_acknowledge/nominal/configs/ast1/extensions.conf > 5053 > > /asterisk/trunk/tests/apps/agents/agent_acknowledge/agent_acknowledge_error/test-config.yaml > 5053 > > /asterisk/trunk/tests/apps/agents/agent_acknowledge/agent_acknowledge_error/configs/ast1/extensions.conf > 5053 > > /asterisk/trunk/tests/apps/agents/agent_acknowledge/agent_acknowledge_error/configs/ast1/agents.conf > 5053 > > Diff: https://reviewboard.asterisk.org/r/3561/diff/ > > > Testing > ------- > > Tests still pass with and without the patch for > https://reviewboard.asterisk.org/r/3551/ applied. > > > Thanks, > > rmudgett > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
