-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3572/#review11989
-----------------------------------------------------------


I'm all for adding the pjsip reload, but the context changes in the template 
seem unnecessary and potentially break systems that depend on the default 
config files.

- Paul Belanger


On May 28, 2014, 8:14 p.m., rnewton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3572/
> -----------------------------------------------------------
> 
> (Updated May 28, 2014, 8:14 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: https://issues.asterisk.org/jira/browse/ASTERISK-23654
>     
> https://issues.asterisk.org/jira/browse/https://issues.asterisk.org/jira/browse/ASTERISK-23654
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> 1. changed naming of included alias templates to avoid confusion between 
> version names. For example, asterisk12 was for asterisk 1.2, so I changed it 
> to asterisk_1dot2, so that later we can use asterisk_12 for Asterisk 12.
> 2. added alias for "features reload" to the template for Asterisk 11 style 
> syntax template, as features reload was removed in 12, but you can still do 
> "module reload features"
> 3. added alias for "pjsip reload" to the friendly template. It is shorter 
> than "module reload res_pjsip.so" and if some are like me; I constantly 
> forget that reloading chan_pjsip doesn't parse config. Remembering "pjsip 
> reload" is just easier.
> 
> 
> Diffs
> -----
> 
>   /branches/12/configs/cli_aliases.conf.sample 414779 
> 
> Diff: https://reviewboard.asterisk.org/r/3572/diff/
> 
> 
> Testing
> -------
> 
> Tested the added aliases.
> 
> 
> Thanks,
> 
> rnewton
> 
>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to