----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3564/#review12006 -----------------------------------------------------------
Ship it! /asterisk/trunk/tests/funcs/func_talkdetect/talk_detect.py <https://reviewboard.asterisk.org/r/3564/#comment21943> I don't think you need to mark FINAL_PLAYBACK as global since you are just reading the value and not writing to it. - Kevin Harwell On May 24, 2014, 11:47 p.m., Matt Jordan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3564/ > ----------------------------------------------------------- > > (Updated May 24, 2014, 11:47 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23786 > https://issues.asterisk.org/jira/browse/ASTERISK-23786 > > > Repository: testsuite > > > Description > ------- > > This adds a test for func_talkdetect. For more information on that function, > see r3563. > > The test consists of four iterations. In each iteration, the same set of > sounds are passed through a Local channel. TALK_DETECT is placed on one half > of the local channel, while playbacks are initiated via ARI on the other > half. Based on the various parameters passed to TALK_DETECT, a different > number of events should be received over AMI/ARI. The iterations are: > - An iteration that sets TALK_DETECT with its default settings. A single > pair of events is expected to be received. > - An iteration that sets TALK_DETECT with a short silence threshold and a > different talk threshold. Two pairs of events are expected to be received. > - An iteration that sets TALK_DETECT with a very short silence threshold. > Three pairs of events are expected to be received. > - An iteration that removes TALK_DETECT. No events should be received. > > The test verifies that a total of 6 event pairs are received (over both > AMI/ARI), and that in the 'end' events, a duration that is non-zero is > present. > > > Diffs > ----- > > /asterisk/trunk/tests/funcs/tests.yaml 5060 > /asterisk/trunk/tests/funcs/func_talkdetect/test-config.yaml PRE-CREATION > /asterisk/trunk/tests/funcs/func_talkdetect/talk_detect.py PRE-CREATION > /asterisk/trunk/tests/funcs/func_talkdetect/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/lib/python/asterisk/ari.py 5060 > > Diff: https://reviewboard.asterisk.org/r/3564/diff/ > > > Testing > ------- > > > Thanks, > > Matt Jordan > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
