----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3579/#review12025 -----------------------------------------------------------
/branches/1.8/funcs/func_odbc.c <https://reviewboard.asterisk.org/r/3579/#comment21969> Red blob, while you're in the neighborhood. /branches/1.8/funcs/func_odbc.c <https://reviewboard.asterisk.org/r/3579/#comment21968> I assume you're going to fix this in trunk? - Tilghman Lesher On June 2, 2014, noon, wdoekes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3579/ > ----------------------------------------------------------- > > (Updated June 2, 2014, noon) > > > Review request for Asterisk Developers and Joshua Colp. > > > Repository: Asterisk > > > Description > ------- > > Mea culpa. > > I okayed r3557, but it introduced a segfault. > https://reviewboard.asterisk.org/r/3557/ > http://lists.digium.com/pipermail/asterisk-commits/2014-May/068614.html > > sql_insert is optional. Previously, this was a static buffer, so it would > never be NULL. > Now it is dynamic and can be NULL, creating trouble. > > > Diffs > ----- > > /branches/1.8/funcs/func_odbc.c 414989 > > Diff: https://reviewboard.asterisk.org/r/3579/diff/ > > > Testing > ------- > > After the patch, asterisk didn't crash on a write query anymore. > > > Thanks, > > wdoekes > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
