----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3585/#review12066 -----------------------------------------------------------
Ship it! Some trivial nits. /branches/12/include/asterisk/channel.h <https://reviewboard.asterisk.org/r/3585/#comment22053> 12.4.0 /branches/12/main/pbx.c <https://reviewboard.asterisk.org/r/3585/#comment22052> Maybe a comment saying we are defensively clearing an escaped UNBRIDGE flag would be nice. - rmudgett On June 5, 2014, 4:27 p.m., Matt Jordan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3585/ > ----------------------------------------------------------- > > (Updated June 5, 2014, 4:27 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This patch is a re-do of review 3535. > > When review request 3535 was merged, a major problem with it was uncovered. > UNBRIDGE soft hangup flags have a catastrophic effect on the pbx core if they > leak out from the bridge layer: the channel gets hung up. With the number of > threads involved in a blind transfer, and with the initial patch, it was > likely that this would occur. This caused a large number of test failures > > This patch is nearly identical with the one proposed in review 3535, save for > the following changes: > - We explicitly clear the UNBRIDGE flag when setting an after goto on a > channel in a bridge > - Defensively, if we encounter an UNBRIDGE flag in the pbx core, we handle it > > > Diffs > ----- > > /branches/12/main/pbx.c 415300 > /branches/12/main/framehook.c 415300 > /branches/12/main/channel.c 415300 > /branches/12/main/bridge_channel.c 415300 > /branches/12/main/bridge_after.c 415300 > /branches/12/include/asterisk/channel.h 415300 > /branches/12/bridges/bridge_native_rtp.c 415300 > > Diff: https://reviewboard.asterisk.org/r/3585/diff/ > > > Testing > ------- > > The blind transfer tests for PJSIP now pass (fingers crossed). See review > 3586. > > > Thanks, > > Matt Jordan > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
