----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3576/#review12070 -----------------------------------------------------------
branches/12/main/astobj2_container.c <https://reviewboard.asterisk.org/r/3576/#comment22058> I had meant to have the reg_containers declaration moved to here but its ok. branches/12/main/astobj2_container.c <https://reviewboard.asterisk.org/r/3576/#comment22059> Placing these conditionals here would be nice: #endif /* defined(AST_DEVMODE) */ #if defined(AST_DEVMODE) branches/12/main/astobj2_container.c <https://reviewboard.asterisk.org/r/3576/#comment22060> This can be conditionaled on AST_DEVMODE because it has nothing to do. Just move the condtionals from inside to outside the function. branches/12/main/astobj2_container.c <https://reviewboard.asterisk.org/r/3576/#comment22061> Move the endif condition to after ast_register_atexit() as it has nothing to do outside of AST_DEVMODE. - rmudgett On June 5, 2014, 5:38 p.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3576/ > ----------------------------------------------------------- > > (Updated June 5, 2014, 5:38 p.m.) > > > Review request for Asterisk Developers and rmudgett. > > > Repository: Asterisk > > > Description > ------- > > In preparation for weak-reference containers, and because it makes the > existing code easier to read and maintain, I've split the astobj2 common > structure and enum definitions and prototypes into astobj2_private.h, the > hash table implementation into astobj2_hash.c, and the rbtree implementation > into astobj2_rbtree.c. All of the public functions remain in astobj2.c. > > A few functions (adjust_lock, container_destruct, container_destruct_debug) > needed to have their static modifiers removed so they'd be visible from the > other object files but other than that there were NO functional changes, no > logic changes, etc. > > EDIT:.. > Also added a basic test to the test framework to monitor performance impacts > as changes are made to astobj2. > > > Diffs > ----- > > branches/12/utils/Makefile 415300 > branches/12/tests/test_astobj2.c 415300 > branches/12/main/astobj2_rbtree.c PRE-CREATION > branches/12/main/astobj2_private.h PRE-CREATION > branches/12/main/astobj2_hash.c PRE-CREATION > branches/12/main/astobj2_container_private.h PRE-CREATION > branches/12/main/astobj2_container.c PRE-CREATION > branches/12/main/astobj2.c 415300 > branches/12/include/asterisk/astobj2.h 415300 > > Diff: https://reviewboard.asterisk.org/r/3576/diff/ > > > Testing > ------- > > I used both the test framework and the test suite. For the test suite, I > used channels/pjsip since that exercises sorcery significantly and that in > turn exercises astobj2. > > All tests that worked before the change worked after the change. > > Before... > > Test Framework > 393 Test(s) Executed 393 Passed 0 Failed > > Test Suite > tests/channels/pjsip/ > Tests: 88 Passed: 87 Failed: 1 > FAILED: tests/channels/pjsip/dialplan_functions/pjsip_endpoint > > After... > > Test Framework > 393 Test(s) Executed 393 Passed 0 Failed > > Test Suite > tests/channels/pjsip/ > Tests: 88 Passed: 87 Failed: 1 > FAILED: tests/channels/pjsip/dialplan_functions/pjsip_endpoint > > Not sure why the pjsip_endpoint function is failing but it's not this patch's > fault. > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
