----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3600/#review12110 -----------------------------------------------------------
The code in AMISendTest.py looks generic enough that it could be used for all 5 tests with the NOTIFY-generating AMI commands and SIPp scenarios defined in YAML. - opticron On June 6, 2014, 3:46 p.m., Jonathan Rose wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3600/ > ----------------------------------------------------------- > > (Updated June 6, 2014, 3:46 p.m.) > > > Review request for Asterisk Developers, Matt Jordan and Mark Michelson. > > > Repository: testsuite > > > Description > ------- > > Tests for the following behavior in PJSIPNotify action: > *PJSIPNotify sends notify messages with specified custom headers > *PJSIPNotify does not override reserved headers > *PJSIPNotify sends notify message content in the order that it was specified > in the manager action > > Tests the following behavior in SIPNotify action: > *SIPNotify sends notify messages with specified custom headers > *SIPNotify sends notify message content in the order that it was specified in > the manager action > > SIPNotify does not prevent modification of reserved headers, so that is not > tested for SIPNotify. Whether or not it should is another question. > > > Diffs > ----- > > /asterisk/trunk/tests/channels/pjsip/ami/tests.yaml 5094 > /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/tests.yaml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/reserved_headers/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/reserved_headers/sipp/options.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/reserved_headers/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/reserved_headers/AMISendTest.py > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/custom_headers/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/custom_headers/sipp/options.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/custom_headers/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/custom_headers/AMISendTest.py > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/content/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/content/sipp/options.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/content/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/content/AMISendTest.py > PRE-CREATION > /asterisk/trunk/tests/channels/SIP/tests.yaml 5094 > /asterisk/trunk/tests/channels/SIP/ami/tests.yaml PRE-CREATION > /asterisk/trunk/tests/channels/SIP/ami/sip_notify/tests.yaml PRE-CREATION > > /asterisk/trunk/tests/channels/SIP/ami/sip_notify/custom_headers/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/channels/SIP/ami/sip_notify/custom_headers/sipp/options.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/SIP/ami/sip_notify/custom_headers/configs/ast1/sip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/SIP/ami/sip_notify/custom_headers/AMISendTest.py > PRE-CREATION > /asterisk/trunk/tests/channels/SIP/ami/sip_notify/content/test-config.yaml > PRE-CREATION > /asterisk/trunk/tests/channels/SIP/ami/sip_notify/content/sipp/options.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/SIP/ami/sip_notify/content/configs/ast1/sip.conf > PRE-CREATION > /asterisk/trunk/tests/channels/SIP/ami/sip_notify/content/AMISendTest.py > PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3600/diff/ > > > Testing > ------- > > Ran tests, mangled the expectations to create failures for each test. > > > Thanks, > > Jonathan Rose > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
