----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3560/#review12134 -----------------------------------------------------------
asterisk/trunk/lib/python/asterisk/sipp.py <https://reviewboard.asterisk.org/r/3560/#comment22157> You may want to run this through pylint. Declaring class member attributes outside of a constructor is a warning under PEP8. You should declare these in the constructor and set them to None. Alternatively, many of these deferreds do not have to be member attributes. You can pass them as arguments to addCallback, which will pass them to the function being called when the deferred is triggered. - Matt Jordan On June 10, 2014, 8:01 a.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3560/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 8:01 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23643 > https://issues.asterisk.org/jira/browse/ASTERISK-23643 > > > Repository: testsuite > > > Description > ------- > > This adds tests for nominal callee- and caller-initiated attended transfer > scenarios using SIPp scenarios and SIPp's 3PCC to coordinate call state. This > also adds another sample SIPp scenario for handling the REFER initiator > behavior as a UAS that works with referee.xml (the UAC attended transfer > coordinator). > > > Diffs > ----- > > asterisk/trunk/tests/channels/pjsip/transfers/tests.yaml 5100 > asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/tests.yaml > PRE-CREATION > > asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/tests.yaml > PRE-CREATION > > asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local/test-config.yaml > PRE-CREATION > > asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local/sipp/uas.xml > PRE-CREATION > > asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local/sipp/referer.xml > PRE-CREATION > > asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local/sipp/referee.xml > PRE-CREATION > > asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local/configs/ast1/pjsip.conf > PRE-CREATION > > asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local/configs/ast1/extensions.conf > PRE-CREATION > > asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local/attended_transfer.py > PRE-CREATION > > asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/test-config.yaml > PRE-CREATION > > asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/sipp/uas.xml > PRE-CREATION > > asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/sipp/uac-no-hangup.xml > PRE-CREATION > > asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/sipp/referer_uas.xml > PRE-CREATION > > asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/sipp/referee.xml > PRE-CREATION > > asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/configs/ast1/pjsip.conf > PRE-CREATION > > asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/configs/ast1/extensions.conf > PRE-CREATION > > asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/attended_transfer.py > PRE-CREATION > asterisk/trunk/lib/python/asterisk/sipp.py 5100 > asterisk/trunk/contrib/sipp/transfer/referer_uas.xml PRE-CREATION > asterisk/trunk/contrib/sipp/table_of_contents 5100 > > Diff: https://reviewboard.asterisk.org/r/3560/diff/ > > > Testing > ------- > > Ensured that the tests performed as expected. > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
