----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3618/#review12144 -----------------------------------------------------------
Revert the changes to chan_sip as they are unrelated to this review. /trunk/apps/app_jack.c <https://reviewboard.asterisk.org/r/3618/#comment22166> Fix tabbing. /trunk/apps/app_jack.c <https://reviewboard.asterisk.org/r/3618/#comment22165> Remove the trailing whitespace. This is commonly called a "red blob" because reviewboard shows it as such. /trunk/apps/app_jack.c <https://reviewboard.asterisk.org/r/3618/#comment22164> Red blob. - opticron On June 13, 2014, 7:19 a.m., Dennis Guse wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3618/ > ----------------------------------------------------------- > > (Updated June 13, 2014, 7:19 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-20696 and ASTERISK-23836 > https://issues.asterisk.org/jira/browse/ASTERISK-20696 > https://issues.asterisk.org/jira/browse/ASTERISK-23836 > > > Repository: Asterisk > > > Description > ------- > > Target: app_jack.c > > Enables the jack-audiohook to cope with dynamic sampling rates from and to > Asterisk. > Information from channel is taken to derive the channel's sampling rate, > suiting SLINxx format and frame->datalen. > > Limitations: > * Required information is taken from channel during initialization as > audiohook does not provide this information then. > Audiohook.internal_sampl_rate(...) is set later, but no callback is available > to inform app_jack. > > * Frame.datalen is computed using "rate / 50" assuming a ptime of 20ms. > There is no internal API available to determine datalen for a SLINxx. > > * Ringbuffer size is a DEFINE and thus must be quite big to be able to cope > with 16Khz+ > > > Diffs > ----- > > /trunk/channels/chan_sip.c 415578 > /trunk/apps/app_jack.c 415578 > > Diff: https://reviewboard.asterisk.org/r/3618/diff/ > > > Testing > ------- > > Checked with jackd and puredata using G.711 and G.722 on Ubuntu 14.0.4 64bit > using Linphone and Ekiga. > > > Thanks, > > Dennis Guse > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
