-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3626/#review12189
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On June 17, 2014, 10:45 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3626/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 10:45 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore and Matt Jordan.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The manager actions for res_parking were being registered with 
> ast_manager_register_xml_core instead of ast_manager_register_xml. Fixing 
> this ran into a small snag when I realized that I couldn't just switch to 
> ast_manager_register_xml since it isn't the same file that actually creates 
> the module, so I'm getting the module info using the same methodology as what 
> was used for registering the core parking functions 
> (include/asterisk/parking.h) and using ast_manager_register2 instead.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/parking/parking_manager.c 416556 
> 
> Diff: https://reviewboard.asterisk.org/r/3626/diff/
> 
> 
> Testing
> -------
> 
> Made sure Asterisk doesn't crash on load, made sure the manager commands are 
> registered and have the appropriate documentation.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to